Give the delivery fixtures room to start git - #11
Merged
Conversation
The 0.2.0 release build failed on one test: a real checkout going from
clean to dirty. The error was `.failed("")` -- an empty stderr, because
git never ran, it timed out. The fixture helper allowed three seconds for
each `git` invocation, and a loaded GitHub runner can spend longer than
that just starting /usr/bin/git.
The test immediately above it already carries a comment saying exactly
this, and already raised its own timeout to ten seconds for the same
reason. The shared helper never got the same treatment.
Fixture setup now allows thirty seconds, and an empty stderr no longer
produces a failure message that says nothing -- it names the command and
the likely cause. The 1.5-second bound the product depends on is in
GitDeliveryReader and is untouched.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
0.2.0release build failed on exactly one test — a real checkout moves from clean to dirty without fetching — with.failed(""). An empty stderr: git never reported anything because it never ran. It timed out.The fixture helper allowed three seconds per
gitinvocation. A loaded GitHub runner can spend longer than that just starting/usr/bin/git.The same file already knew this. The test directly above carries a comment saying a loaded runner "can spend more than two seconds starting
/usr/bin/git" and raises its own timeout to ten for that reason. The shared helper every other test goes through never got the same treatment.GitDeliveryReaderand is untouched.Test plan
swift test --filter DeliverySnapshot: 5 tests green.swift test: full suite green.🤖 Generated with Claude Code