Skip to content

kboot: Stop using non-upstream, undocumented OF "/aliases" - #768

Open
jannau wants to merge 4 commits into
AsahiLinux:mainfrom
jannau:fdt-unalias-phase-1
Open

jannau wants to merge 4 commits into
AsahiLinux:mainfrom
jannau:fdt-unalias-phase-1

Conversation

@jannau

@jannau jannau commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Our use of "/aliases" in the devicetree is not upstreamable. The "touchbar%d" and "atcphy%d" aliases sneaked in but where removed today and expected to land in Linux v7.5.

Replace their use with plain iterating over device nodes and matching their ADT equivalent via MMIO addresses or keep the hardcoded matching for the 2 known devices in the case of the touchbar0 alias.

This handles just the removed "upstream" aliases. Not yet upstream devices which use "/aliases" still have to be rewritten at least before their driver is submitted upstream.
The serial, bluetooth, wifi and ethernet aliases can stay.


Please check all boxes that apply:

  • This code was developed in accordance with the Asahi Linux Copyright Policy
  • I have not used generative AI/LLMs to develop this code, in accordance with the Asahi Linux LLM Policy
  • I have certified the above by adding a Signed-off-by: trailer to every commit

All boxes must be checked before your pull request can be reviewed.

This survived longer than expected.

Signed-off-by: Janne Grunau <j@jannau.net>
New "/aliases" properties should not have been added. In addition this
one was undocumented.

Signed-off-by: Janne Grunau <j@jannau.net>
The use of "/aliases" to match FDT nodes to ADT nodes for copying device
specific data like tuneables is not desired in upstream devicetrees. One
alternative is to iterate over all FDT nodes and find matching ADT nodes
by comparing addresses. dt_disable_missing_devs() already does the same
so factor common functionality out for re-use.
No functional changes intended.

Signed-off-by: Janne Grunau <j@jannau.net>
New "/aliases" properties should not have been added. In addition these
were not documented in the apple,atcphy dt-bindings.
Instead of using the aliases iterate over all "/soc*" child device nodes
and match FDT and ADT atc-phy device nodes by their "core" MMIO address.

Signed-off-by: Janne Grunau <j@jannau.net>
@jannau
jannau requested a review from svenpeter42 as a code owner November 17, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant