Repository navigation
Conversation
This survived longer than expected. Signed-off-by: Janne Grunau <j@jannau.net>
New "/aliases" properties should not have been added. In addition this one was undocumented. Signed-off-by: Janne Grunau <j@jannau.net>
The use of "/aliases" to match FDT nodes to ADT nodes for copying device specific data like tuneables is not desired in upstream devicetrees. One alternative is to iterate over all FDT nodes and find matching ADT nodes by comparing addresses. dt_disable_missing_devs() already does the same so factor common functionality out for re-use. No functional changes intended. Signed-off-by: Janne Grunau <j@jannau.net>
New "/aliases" properties should not have been added. In addition these were not documented in the apple,atcphy dt-bindings. Instead of using the aliases iterate over all "/soc*" child device nodes and match FDT and ADT atc-phy device nodes by their "core" MMIO address. Signed-off-by: Janne Grunau <j@jannau.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our use of "/aliases" in the devicetree is not upstreamable. The "touchbar%d" and "atcphy%d" aliases sneaked in but where removed today and expected to land in Linux v7.5.
Replace their use with plain iterating over device nodes and matching their ADT equivalent via MMIO addresses or keep the hardcoded matching for the 2 known devices in the case of the touchbar0 alias.
This handles just the removed "upstream" aliases. Not yet upstream devices which use "/aliases" still have to be rewritten at least before their driver is submitted upstream.
The serial, bluetooth, wifi and ethernet aliases can stay.
Please check all boxes that apply:
Signed-off-by:trailer to every commitAll boxes must be checked before your pull request can be reviewed.