Skip to content

[DRAFT] Add Rigol instrument#8

Draft
VitorRamos wants to merge 1 commit into
Arkh42:masterfrom
VitorRamos:master
Draft

[DRAFT] Add Rigol instrument#8
VitorRamos wants to merge 1 commit into
Arkh42:masterfrom
VitorRamos:master

Conversation

@VitorRamos
Copy link
Copy Markdown

Draft of DS1102E support

Copy link
Copy Markdown
Owner

@Arkh42 Arkh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the code: the DS1102E inherits from Electrometer instead of Oscilloscope. I defined the minimum functions to implement in the oscilloscope.py file. I'm sending a commit ASAP.

@VitorRamos VitorRamos marked this pull request as draft July 7, 2021 11:35
@VitorRamos
Copy link
Copy Markdown
Author

Yes, this PR is not complete yet. I created this draft so that we can discuss the implementation details in case anything needs to change.
The DS1102E class, for now, is just a copy of one of the electrometers with the correct query format, the SCPI commands were also not updated yet.
For the oscilloscope class, I ​wasn't sure there's enough difference between an electrometer and an oscilloscope for this project, so I didn't create anything. But in this case, I wait for the base class.

@Arkh42
Copy link
Copy Markdown
Owner

Arkh42 commented Jul 7, 2021

The base class is now committed.
You can find it in https://github.com/Arkh42/rtestbench/tree/master/rtestbench/tools/oscilloscope.py

@Arkh42 Arkh42 assigned Arkh42 and unassigned Arkh42 Jul 7, 2021
@Arkh42 Arkh42 added the enhancement New feature or request label Jul 7, 2021
@Arkh42
Copy link
Copy Markdown
Owner

Arkh42 commented Jul 7, 2021

I also forgot to mention to write the corresponding test functions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants