test(google_adk): allow pre-release opentelemetry-resourcedetector-gcp to fix dependency resolution - #3427
Merged
Conversation
…p to fix dependency resolution
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
google_adkcanary: dependency resolution failureRoot cause
The canary cron's
py310-ci-google_adk-latestandpy314-ci-google_adk-latestenvironments failed at the
uv pip install -r test-requirements.txtstep (beforeany tests ran) with an unsatisfiable resolution:
This is an upstream packaging change, not a code regression:
google-adk(viaopentelemetry-exporter-gcp-trace) now pulls inopentelemetry-exporter-gcp-trace>=1.9.0.opentelemetry-exporter-gcp-tracereleases requireopentelemetry-resourcedetector-gcp>=1.5.0.dev0, which is only published as apre-release (e.g.
1.12.0a0); no matching stable release exists.pre-release marker in a direct requirement. Because the marker only appears
transitively, uv refused to select the pre-release and resolution failed. The
uv hint in the log spells this out.
Fix
Add
opentelemetry-resourcedetector-gcp>=1.5.0.dev0as a direct entry in thepackage's
test-requirements.txt. The explicit pre-release marker tells uv it mayselect the pre-release for that package, allowing the
google-adkdependency tree(
opentelemetry-exporter-gcp-trace 1.12.0/opentelemetry-resourcedetector-gcp 1.12.0a0) to resolve. This is a test-only change; the instrumentor's runtimedependencies are unchanged.
Validation
Ran from the repository root:
Both environments now resolve dependencies, upgrade to
google-adk==2.5.0(latest),and pass: 24 passed each, with
ruff format,ruff check, andmypyall clean.