Support for blocks that are not cubes: Placing static mesh instances instead! Like a tree!#36
Open
miguelemosreverte wants to merge 7 commits intoAndrewScheidecker:masterfrom
Open
Conversation
This change improves compile time, like, for realsies. From minutes to 20 seconds tops. All credit should go to the french developing team @JohnsonJackblue is part of, they where the ones who discovered this!
Merging with master from parent
…d of cubes. On the next commit I will show how to delete this added static meshes instances when a render chunk is no longer rendered. The reason this is such a clean commit, and the next is coming soon is that this feature had already been developed a few months ago, with the help of @JohnsonJackblue and even the help of @AndrewScheidecker himself, who pointed us both to the obvious: Why try to hardcode the vertex positions like Minecraft did when we could just place UInstancedStaticMeshComponents instead, using the bricks coordinates as grid. Well, that has been done now, and will be updated in the next commit too. Cheers!
miguelemosreverte
changed the title
…up to 255 available options, where if the selected material index is bigger than Parameters.Materials.Num() then it is considered the index of a complex brick and then a complex brick is spawned. Now an invisible block is placed where the complex block is, so that new blocks can be placed on top of it as if it were a normal block.
…o avoid changing them later when they surpass the lenght of Paramenters.Materials, to zero.
…deleted using right click.
Contributor
Author
|
Its done! Ready for merge! Pic where it can be seen that the complex brick is treated as a normal one, and adjacent bricks can be placed on top of it. About the correct deletion and restore of the complex bricks once a render chunk is deleted and restored... you will have to take my word up for it! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29 by using a cleaner version of my ComplexShapes branch, ComplexMeshes2.
Dont merge the PR yet, I have yet to commit the deletion of the instanced meshes once a render chunk is deleted. Once thats done, we are good to go. Will do so in an hour or two. Cheers!