Open
Conversation
Fix AltSchool#50 This PR migrate broccoli-react to broccoli-babel-transpiler. This brings us to more updated ember tooling. Some dependencies were upgraded to make this work though: - Minimum NodeJS bumped to v10 - Upgraded Ember CLI - Upgraded ember-cli-babel to v7 - Migrated ember-cli-mocha to ember-mocha
Currently we test against hardcoded Ember version to load some important internals. Instead of doing that, this PR changes it to be a trials and error approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it has been a while, this PR will track any updates from my fork at https://www.npmjs.com/package/ember-cli-react-fork.