Skip to content

Fix mac build, upload windows artifacts #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mouzedrift merged 2 commits into from
Feb 27, 2026
Merged

Fix mac build, upload windows artifacts #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e87c0d5
Fix mac build, upload windows artifacts
mouzedrift Feb 27, 2026
44d32f2
Always trigger GitHub CI
mouzedrift Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 24 additions & 28 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@ name: CI

on:
push:
branches: [master]
pull_request:
branches: [master]

# build setting(s)
env:
CONFIGURATION: Debug
CONFIGURATION: Release

jobs:
build:
Expand All @@ -23,7 +21,7 @@ jobs:
name: Windows64
- os: ubuntu-latest
name: Linux
- os: macos-13
- os: macos-26
name: macOS

steps:
Expand All @@ -50,7 +48,10 @@ jobs:
cd build
cmake .. -G"Visual Studio 17 2022" -DCMAKE_PREFIX_PATH="$env:QT_ROOT_DIR" -A Win32
cmake --build . --config $env:CONFIGURATION
cpack -G ZIP -C $env:CONFIGURATION
cd $env:CONFIGURATION
mkdir deploy
move qt-editor.exe ./deploy
windeployqt qt-editor.exe --no-translations --no-system-d3d-compiler --no-angle --no-opengl-sw --no-svg --dir ./deploy --plugindir ./deploy/plugins

# ======================================
# Windows64
Expand All @@ -70,7 +71,10 @@ jobs:
cd build
cmake .. -G"Visual Studio 17 2022" -DCMAKE_PREFIX_PATH="$env:QT_ROOT_DIR" -A x64
cmake --build . --config $env:CONFIGURATION
cpack -G ZIP -C $env:CONFIGURATION
cd $env:CONFIGURATION
mkdir deploy
move qt-editor.exe ./deploy
windeployqt qt-editor.exe --no-translations --no-system-d3d-compiler --no-angle --no-opengl-sw --no-svg --dir ./deploy --plugindir ./deploy/plugins

# ======================================
# Linux
Expand Down Expand Up @@ -118,30 +122,22 @@ jobs:
# Artifacts
# ======================================

- name: 'Windows: Upload qt-editor binaries'
if: runner.os == 'Windows'
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.name }}-${{ env.CONFIGURATION }}-qt-editor
path: build\${{ env.CONFIGURATION }}\deploy

- name: 'Linux: Upload qt-editor deb'
if: matrix.name == 'Linux'
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.name }}-${{ env.CONFIGURATION }}-qt-editor.deb
path: build/qt-editor-0.1.1-Linux.deb

# TODO

# - name: 'Windows: Upload qt-editor binaries'
# if: runner.os == 'Windows'
# uses: actions/upload-artifact@v4
# with:
# name: ${{ matrix.name }}-${{ env.CONFIGURATION }}-qt-editor
# path: |
# build\${{ env.CONFIGURATION }}\qt-editor.exe
# build\${{ env.CONFIGURATION }}\SDL2.dll

# - name: 'Windows: Upload qt-editor symbols'
# uses: actions/upload-artifact@v4
# with:
# name: ${{ matrix.name }}-${{ env.CONFIGURATION }}-qt-editor-symbols
# path: build\${{ env.CONFIGURATION }}\qt-editor.pdb

# - name: 'Linux: Upload qt-editor deb'
# if: matrix.name == 'Linux'
# uses: actions/upload-artifact@v4
# with:
# name: ${{ matrix.name }}-${{ env.CONFIGURATION }}-qt-editor.deb
# path: build/qt-editor-0.1-Linux.deb

# - name: 'macOS: Upload relive dmg'
# if: matrix.name == 'macOS'
# uses: actions/upload-artifact@v4
Expand Down
Loading