Skip to content

[OGUI-1661] Object tree breaking when collapsing parents without first collapsing children #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graduta merged 10 commits into from
Jan 5, 2026
Merged

[OGUI-1661] Object tree breaking when collapsing parents without first collapsing children #3234

graduta merged 10 commits into from
Jan 5, 2026

Conversation

@hehoon
Copy link
Collaborator

@hehoon hehoon commented Dec 13, 2025 •
edited
Loading

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

To fix the issue the following has been done:

  • Replace map with flatMap in recursive treeRow traversal

In addition to this:

  • Prevent redundant notify() calls during deep tree operations
  • Perform minor code cleanup for clarity and maintainability

@hehoon hehoon self-assigned this Dec 13, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2025
View reviewed changes
@hehoon @github-advanced-security
Fix useless conditional
c7f8ca1 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@hehoon hehoon marked this pull request as ready for review December 15, 2025 12:36
@hehoon hehoon requested a review from graduta as a code owner December 15, 2025 12:36
graduta
graduta requested changes Dec 16, 2025
View reviewed changes
Copy link
Member

@graduta graduta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good bug fix!
Looking at branchRow and leafRow, I think these have a lot of duplicated code and we should make one reusable component. What do you think?

@hehoon hehoon requested a review from graduta December 17, 2025 09:58
graduta
graduta requested changes Dec 17, 2025
View reviewed changes
@hehoon hehoon requested a review from graduta December 17, 2025 15:02
@graduta graduta merged commit 6fdcb20 into dev Jan 5, 2026
5 checks passed
@graduta graduta deleted the bug/QCG/OGUI-1661/object-tree-breaks-vnode-lifecycle branch January 5, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

Assignees

@hehoon hehoon

Labels

Frontend Quality Control

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hehoon @graduta