Skip to content

[Common,DPG,Tutorial,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD] Clean remaining usage of PIDResponse.h #14438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
njacazio wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Common,DPG,Tutorial,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD] Clean remaining usage of PIDResponse.h #14438

njacazio wants to merge 5 commits into from

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jan 9, 2026

  • Using PIDResponseTOF and PIDResponseTPC

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

O2 linter results: ❌ 1111 errors, ⚠️ 1096 warnings, 🔕 1 disabled

@github-actions github-actions bot changed the title Clean remaining usage of PIDResponse.h [Common,DPG,Tutorial,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD] Clean remaining usage of PIDResponse.h Jan 9, 2026
@alibuild alibuild mentioned this pull request Jan 9, 2026
Merged
njacazio pushed a commit that referenced this pull request Jan 9, 2026
@alibuild
Please consider the following formatting changes to #14438 (#14439)
3a5e17e
@njacazio
Clean remaining usage of PIDResponse.h
fe4a497 
- Using PIDResponseTOF and PIDResponseTPC
@njacazio njacazio force-pushed the njacazio-patch-clean-pidresponse branch from 3a5e17e to fe4a497 Compare January 9, 2026 09:40
@njacazio njacazio marked this pull request as ready for review January 12, 2026 16:57
@alibuild
Copy link
Collaborator

alibuild commented Jan 12, 2026

Error while checking build/O2Physics/o2 for b92580c at 2026-01-12 21:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14438-slc9_x86-64/0/PWGLF/Tasks/Resonances/chk892Flow.cxx:26:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

rolavick
rolavick previously approved these changes Jan 13, 2026
View reviewed changes
romainschotter
romainschotter previously approved these changes Jan 13, 2026
View reviewed changes
dsekihat
dsekihat previously approved these changes Jan 13, 2026
View reviewed changes
mcoquet642
mcoquet642 previously approved these changes Jan 13, 2026
View reviewed changes
alcaliva
alcaliva previously approved these changes Jan 14, 2026
View reviewed changes
@njacazio njacazio disabled auto-merge January 14, 2026 10:42
ddobrigk
ddobrigk previously approved these changes Jan 14, 2026
View reviewed changes
skundu692
skundu692 previously approved these changes Jan 15, 2026
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Jan 15, 2026

Error while checking build/O2Physics/o2 for 2643f28 at 2026-01-15 17:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14438-slc9_x86-64/0/PWGLF/Tasks/Resonances/rho770analysis.cxx:24:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
Refactor rho770analysis for PID modes and histogram updates
bc4d8d5 
Updated the rho770analysis.cxx file to include new PID selection modes, adjust TPC cluster settings, and improve histogram filling with multiplicity. Refactored the handling of particle types and added new includes for better functionality.
@njacazio
Copy link
Collaborator Author

njacazio commented Jan 16, 2026

Apologies, due to the extent of the changes any new change has to be reapproved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolavick rolavick rolavick approved these changes

@dsekihat dsekihat dsekihat approved these changes

@victor-gonzalez victor-gonzalez victor-gonzalez left review comments

@ddobrigk ddobrigk ddobrigk left review comments

@alcaliva alcaliva alcaliva left review comments

@romainschotter romainschotter romainschotter left review comments

@mcoquet642 mcoquet642 mcoquet642 left review comments

@skundu692 skundu692 skundu692 left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@amatyja amatyja Awaiting requested review from amatyja amatyja is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

@noferini noferini Awaiting requested review from noferini noferini is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@catalinristea catalinristea Awaiting requested review from catalinristea catalinristea is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

+1 more reviewer

@omvazque omvazque omvazque approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

common datamodel dpg pwgcf pwgdq pwgem pwglf pwgud tutorial

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.