-
Notifications
You must be signed in to change notification settings - Fork 620
[PWGLF,DPG] tpcSkimsTableCreator: add columns and refactor code #14307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alcaliva
merged 23 commits into
AliceO2Group:master
from
lubynets:tpcSkimCreatorRefactor
Jan 7, 2026
Merged
[PWGLF,DPG] tpcSkimsTableCreator: add columns and refactor code #14307
alcaliva
merged 23 commits into
AliceO2Group:master
from
lubynets:tpcSkimCreatorRefactor
Jan 7, 2026
+556
−593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 34 errors, |
romainschotter
previously approved these changes
Dec 21, 2025
romainschotter
approved these changes
Dec 28, 2025
alcaliva
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement:
processWithTrQA()function yet another workflow,o2-analysis-occ-table-producer, is required;Code cleaning and refactoring:
run()) for cases without and with QA are merged into a single one. Theprocess()functions are kept separate, so no subscription for unneeded (or unavailable) tables is required. The observed behavior for the user is not changed;StandardandWithDeDxTrkQaare merged into a single one, since before they differed only by one column,TPCdEdxNorm. Now this column is filled with a proper value in case of call theprocessWithdEdxTrQA()function and with an arbitrary value -999 in case of call theprocessStandard()function;utilsTpcSkimsTableCreator.h;Tagging @amaringarcia