[PWGHF] Add preselection and centrality to st tree creator #14252
+349
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a name bug.
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
Added new mass columns for Omega and Xi particles and updated event selection criteria.
…ty-to-STTree-creatore
…ty-to-STTree-creatore
FDUEnrich
requested review from
alibuild,
fcatalan92,
fcolamar,
fgrosa,
mfaggin and
vkucera
as code owners
Collaborator
|
Stop wasting compilation resources! Your PR doesn't pass required tests and you haven't addressed my comments, so why did you open the PR for review? |
Please consider the following formatting changes to AliceO2Group#14252
vkucera
reviewed
Dec 19, 2025
| setLabelHistoCands(hCandidatesCascPiOrK); | ||
|
|
||
| // init HF event selection helper (centrality, event cuts, monitoring) | ||
| hfEvSel.init(registry, nullptr); |
Contributor
Author
There was a problem hiding this comment.
Hi, Vit. This is recommended by Fabrizio.
…ty-to-STTree-creatore
vkucera
reviewed
Dec 21, 2025
vkucera
reviewed
Dec 24, 2025
Collaborator
vkucera
reviewed
Jan 8, 2026
Comment on lines
296
to
299
| Configurable<float> impactParameterCascYMax{"impactParameterCascYMax", 10.f, "Max abs Max abs impactParameter of cascade(Y)"}; | ||
| Configurable<float> absDcaCascZMax{"absDcaCascZMax", 10.f, "Max abs DCA Z of cascade"}; | ||
| Configurable<float> impactParameterCharmBachelorYMax{"impactParameterCharmBachelorYMax", 10.f, "Max abs impactParameter of charm bachelor(Y)"}; | ||
| Configurable<float> absDcaCharmBachelorZMax{"absDcaCharmBachelorZMax", 10.f, "Max abs DCA Z of charm bachelor"}; |
Collaborator
There was a problem hiding this comment.
Please clarify which cuts are applied on absolute values. Now there is a mismatch between the names and the descriptions.
vkucera
reviewed
Jan 8, 2026
Comment on lines
355
to
356
| {"hMassXiPi", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2})", {HistType::kTH1D, {{400, 1.5, 3.}}}}, | ||
| {"hMassXiPiVsPt", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2});p_{T} (GeV/#it{c})", {HistType::kTH2D, {{400, 1.5, 3.}, {10, 0., 10.}}}}, |
vkucera
reviewed
Jan 8, 2026
Comment on lines
808
to
810
| default: | ||
| passSelectedChannel = true; // unexpected code -> do not reject | ||
| break; |
Collaborator
There was a problem hiding this comment.
Why do you silently accept unexpected cases?
…ty-to-STTree-creatore
Updated variable names for clarity and consistency in the treeCreatorOmegacSt.cxx file. Removed unused histogram for mass Xi + pi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.