Skip to content

[WIP] Add modern mode #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phil294 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] Add modern mode #199

phil294 wants to merge 5 commits into from

Conversation

@phil294
Copy link

@phil294 phil294 commented May 30, 2020 •
edited
Loading

Fixes #28

912dcb7dd52746d4
Outputs for example

/dist/js/app.27e17d15.js
/dist/js/app.27e17d15.js.map
/dist/js/app-legacy.00aa67e8.js
/dist/js/app-legacy.00aa67e8.js.map
etc.

and

<html>
[...]
<!--vue-ssr-outlet-->
{{{ renderState() }}}
{{{ renderScripts() }}}
<script type=module src=/js/chunk-vendors.a9109a24.js></script>
<script type=module src=/js/app.27e17d15.js></script>
<script src=/js/safari-nomodule-fix.js></script>
<script src=/js/chunk-vendors-legacy.3b5a3d7d.js nomodule></script>
<script src=/js/app-legacy.00aa67e8.js nomodule></script>
</body></html>

Just like a normal non-ssr --modern build.
Couple problems persist, I'll just review my own pull request below for code comments

phil294 and others added 5 commits March 23, 2020 13:25
@phil294
Always remove extract-css-loader on server
d19fb4f 
... even when `cricitcalCSS` is disabled. This fixes the `document is not defined` bug in production mode
Fixes Akryum#186
@phil294
refactor(webpack): Remove some unnecessary nesting
7c8724d
@phil294
Make compile a seperate async function
a01e8fd 
So it can be called multiple times, even asynchronously
@phil294
Build in modern mode
a59c3a2 
Always build in modern mode (even in dev mode), config option for this is still missing.
There are now three webpack configs, two client (modern/legacy) ones and one for the server.
@phil294
Undo accidental commit
28fb796 
From a seperate branch / pull request, not related to this one
@phil294 phil294 mentioned this pull request May 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build in modern mode

1 participant

@phil294