Skip to content

fix: clear cache when re-creating bundle renderer #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsanders11 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clear cache when re-creating bundle renderer #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,19 @@ module.exports = (app, options) => {
server: app,
templatePath,
onUpdate: ({ serverBundle }, options) => {
// Re-create the bundle renderer
renderer = createBundleRenderer(serverBundle, {
const mergedOptions = {
...defaultRendererOptions,
...options,
})
}

// Re-using the cache could lead to out-of-date results,
// so clear the cache on bundle renderer rebuild
if (mergedOptions.cache && mergedOptions.cache.reset) {
mergedOptions.cache.reset()
}

// Re-create the bundle renderer
renderer = createBundleRenderer(serverBundle, mergedOptions)
},
})
}
Expand Down