Fix IndexError in udiff find_diffs on a +++ header with no --- line#5369
Draft
ikatyal2110 wants to merge 1 commit into
Draft
Fix IndexError in udiff find_diffs on a +++ header with no --- line#5369ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
… line A unified diff whose "+++ " line isn't preceded by a "--- " line (a common shape for malformed model output) indexed hunk[-2]/hunk[-3] on a short hunk and raised IndexError, crashing instead of letting the malformed-edit retry path handle it. Guard the indexing with length checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_diffs crashed with IndexError on a malformed unified diff where a '+++ ' line isn't preceded by a '--- ' line — it indexed hunk[-2]/hunk[-3] on a one-element hunk. Added length guards so it parses without crashing and the normal malformed-edit retry can kick in instead. Added a test.