fix: remove shell=True in cmd_git to prevent command injection (issue #5272)#5363
Open
chrislazar25 wants to merge 1 commit into
Open
fix: remove shell=True in cmd_git to prevent command injection (issue #5272)#5363chrislazar25 wants to merge 1 commit into
chrislazar25 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix command injection vulnerability in
/gitby removingshell=Trueand using list-based subprocess invocation.Technical Details:
cmd_git()constructs"git " + argsand passes it tosubprocess.run(..., shell=True). User input is concatenated directly into a shell command string, allowing injection via shell metacharacters (;,|,`, etc.)./git status; cat ~/.ssh/id_rsato execute the injected command after git ran. The fix switches to a list-based call (["git"] + shlex.split(args)withshell=False), so shell metacharacters become literal git arguments that git rejects as unknown commands.Verification:
python -m pytest tests/. 455 passed, 1 pre-existing env failure (test_voice requires audio hardware). Pre-commit hooks (isort, black, flake8, codespell) all green.git status→ exit 0, correct output ✅git log --oneline -1→ exit 0, correct output ✅git status; echo INJECTED_YES(old code):INJECTED_YESappeared in output — exploitablegit status; echo INJECTED_YES(new code): exit 1,git: 'status;' is not a git command— blocked ✅Blast Radius:
/gitcommands that previously worked as shell syntax will now fail. These were security bugs, not intended features.shlex.split()handles quoted arguments correctly (more robust than a naive.split()).Fixes #5272