Fix IndexError in strip_quoted_wrapping for filename-only content#5355
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix IndexError in strip_quoted_wrapping for filename-only content#5355ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
When a block's content is just the filename line, stripping that line leaves res empty, and the fence check then indexed res[0]/res[-1] on an empty list and raised IndexError. Guard it with `if res`, like the trailing-newline check right below already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strip_quoted_wrapping raised IndexError when a block's content was just a filename line — after dropping that line res is empty, and the fence check then indexed res[0]/res[-1]. Added the same 'if res' guard the trailing-newline check right below it already uses, plus a test. This may be the cause of #3855.