fix: create new files in the subtree cwd under --subtree-only#5340
Open
rodboev wants to merge 1 commit into
Open
fix: create new files in the subtree cwd under --subtree-only#5340rodboev wants to merge 1 commit into
rodboev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make subtree-only sessions create new relative files inside the current cwd subtree instead of the git root. This covers both unmatched
/addpaths and model-created files, while keeping tracked-file and non-subtree path semantics unchanged.Why
--subtree-onlyalready scopes visibility to the current subtree, but new-file creation still resolves from repo root. In monorepos that forces files into the wrong directory even when the whole session is intentionally scoped to a subproject.Attribution
Scope follows gregid's monorepo report quoted in #3329 from #312 (comment).
Tests
python -m pytest tests/basic/test_commands.py::TestCommands::test_cmd_add_subtree_only_creates_unmatched_file_in_cwd tests/basic/test_coder.py::TestCoder::test_allowed_to_edit_subtree_only_creates_new_file_in_cwd tests/basic/test_coder.py::TestCoder::test_allowed_to_edit_without_subtree_only_keeps_repo_root_for_new_files tests/basic/test_coder.py::TestCoder::test_allowed_to_edit_subtree_only_keeps_repo_relative_subtree_paths tests/basic/test_repo.py::TestRepo::test_subtree_only_new_file_path_resolution -vpre-commit run --all-filesCloses #3329