fix: trim whitespace-only search and add missing param-count test#996
Open
Ghadaffijr wants to merge 1 commit into
Open
fix: trim whitespace-only search and add missing param-count test#996Ghadaffijr wants to merge 1 commit into
Ghadaffijr wants to merge 1 commit into
Conversation
- Agora-Events#826: Normalize filters.search by trimming whitespace and treating whitespace-only input as no search term, preventing the % % ILIKE pattern from matching every event in the search filter - Agora-Events#825: Add the unit test required by the acceptance criteria, confirming start_date + end_date together produce the expected param_count of 2 in build_event_where_clause. The underlying parameter binding fix for the count query was already present on dev; this PR adds the missing test coverage called for in the issue. Closes Agora-Events#825 Closes Agora-Events#826
|
@Ghadaffijr is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ghadaffijr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #825
Closes #826