Skip to content

Fix ACF REST field registration for built-in tags #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harugon wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −1
Open

Fix ACF REST field registration for built-in tags #1008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e1354
Fix ACF REST field registration for built-in tags
harugon Mar 28, 2026
1935d15
Merge pull request #1 from harugon/fix/rest-term-post-tag-acf-registr…
harugon Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion includes/rest-api/class-acf-rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ public function register_field() {

$base = $this->request->object_sub_type;

// WordPress term controllers use the schema title as the object type for
// additional REST fields. For built-in tags, the taxonomy is "post_tag"
// but the REST object type is "tag".
if ( 'term' === $this->request->object_type && 'post_tag' === $base ) {
$base = 'tag';
}

// If the object sub type ($post_type, $taxonomy, 'user') cannot be determined from the current request,
// we don't know what endpoint to register the field against. Bail if that is the case.
if ( ! $base ) {
Expand Down Expand Up @@ -218,7 +225,12 @@ public function load_fields( $object, $field_name, $request, $object_sub_type )
return $fields;
}

$object_sub_type = str_replace( '-revision', '', $object_sub_type );
// Preserve the taxonomy slug for ACF field-group matching.
if ( 'term' === $object_type && $this->request->object_sub_type ) {
$object_sub_type = $this->request->object_sub_type;
} else {
$object_sub_type = str_replace( '-revision', '', $object_sub_type );
}

// Get all field groups for the current object.
$field_groups = $this->get_field_groups_by_id( $object_id, $object_type, $object_sub_type );
Expand Down Expand Up @@ -285,6 +297,11 @@ public function update_fields( $data, $object, $property, $request, $object_sub_
);
}

// Preserve the taxonomy slug for ACF field-group matching.
if ( 'term' === $object_type && $this->request->object_sub_type ) {
$object_sub_type = $this->request->object_sub_type;
}

// Determine the ACF selector for the current object.
$post_id = $this->make_identifier( $object_id, $object_type );

Expand Down
Loading