Conversation
| ports: | ||
| - 5432:5432 | ||
|
|
||
| adminer: |
There was a problem hiding this comment.
Pretty sure this isn't required so I think we can just get rid of it.
|
Do you have a proposal for changing the production environment variables? I think I'd be keen to instead have another settings file, possibly something like |
generally with docker files you want to emulate whats in production as closely as possible, I also dislike config files in general as its just another thing thats different to prod, I think itd be pretty simple to just change the production config slightly and change the env vars, for exmaple atm in prod it does some fancy string manipulation to get the postgres user and stuff like that where that info could just be capture in the env variable |
The different settings options though exist to support the different environments in which the application is running. You say you spun this up, did you try and upload a script to the database with a PDF? I suspect that will fail because Also at the moment I do allow production to enter DEBUG mode with an environment variable but I should probably remove that. That would mean the docker environment wouldn't have useful debug error messages in the web browser such as seeing what's wrong with 404 errors, exceptions etc. So I think my preference would still be to store this as a separate |
wanted to spin up something so just got this spun up, I haven't really used django or python in prod much before so let me know if any of this is wrong
note: theres weird names for some of the env variables as i use the production config and just give them differnet values. Id like to change this so these env vars are clean but didnt want to change anything for production in this PR : )