Open
Conversation
ijlee2
force-pushed
the
unpod-components
branch
2 times, most recently
from
ee5b5fc to
a5932a7
Compare
Contributor
Author
|
@mixonic Can you help review this PR and rerun the failing |
|
+1 from me for v2 addon support. |
ijlee2
force-pushed
the
unpod-components
branch
from
a5932a7 to
d7f5a05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We use and maintain a fork of
ember-tableat work, and noticed that the pod structure is still used for components. Generally speaking,ember-source@6.0.0removed pod support for components, soember-tablemay end up becoming a blocker to developers who want to update Ember to v6.I suspect that the
ember-releasescenario (i.e.6.4.0) is currently passing, because the classic components make use of thelayoutkey. Removing the pod structure now would help maintainers and contributors glimmerize these components (Glimmer + pod doesn't work) and introduce the v2 addon format.What changed?
I introduced the flat component structure, which is the default structure in Ember Octane and works without an issue in v2 addons.
Note
You can ignore the first 7 commits. Once #1172 is merged, I'll rebase this branch so that only the last commit remains.
I didn't remove the pod structure in
tests/dummy.ember-cli-addon-docshadn't been set up for local development, so I wouldn't have been able to test the unpodding easily.