-
Notifications
You must be signed in to change notification settings - Fork 81
Fix malformed build script in @guildpass/integration-client package.json #332
Copy link
Copy link
Closed
Labels
Third CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsbugConfirmed defect or incorrect behavior that needs to be fixedConfirmed defect or incorrect behavior that needs to be fixedbuildBuild configuration, compilation, packaging, and build-system improvementsBuild configuration, compilation, packaging, and build-system improvementsintermediateIntermediate difficulty tasks requiring solid experience and some contextIntermediate difficulty tasks requiring solid experience and some context
Description
Activity
Metadata
Metadata
Assignees
Labels
Third CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsbugConfirmed defect or incorrect behavior that needs to be fixedConfirmed defect or incorrect behavior that needs to be fixedbuildBuild configuration, compilation, packaging, and build-system improvementsBuild configuration, compilation, packaging, and build-system improvementsintermediateIntermediate difficulty tasks requiring solid experience and some contextIntermediate difficulty tasks requiring solid experience and some context
Background
During workspace build (
pnpm -r build), the@guildpass/integration-clientpackage fails with:This error occurs because the TypeScript CLI receives conflicting arguments:
-p tsconfig.json(which signals a project build) followed by additional source file arguments.Problem
The
packages/integration-client/package.jsonbuildscript contains extra text appended to the TypeScript command:This concatenation results in TypeScript receiving invalid arguments, causing the entire workspace build to fail at this step.
Expected Outcome
The
@guildpass/integration-clientbuild script is corrected to run only the TypeScript compilation step without extraneous commands appended.Suggested Implementation
packages/integration-client/package.json"build"script entry"tsc -p tsconfig.json"pnpm build -r --filter @guildpass/integration-clientto confirm it compiles without errorspnpm -r buildAcceptance Criteria
packages/integration-client/package.jsoncontains a cleanbuildscript with onlytsc -p tsconfig.jsonpnpm build -r --filter @guildpass/integration-clientcompletes without TypeScript errorspnpm -r buildsucceeds past the integration-client stepAffected Files/Directories
packages/integration-client/package.json