Repository navigation
ci: fxcss 0.20.0 — the audit stops guessing across documents - #222
Merged
Merged
Conversation
0.20.0 carries two selector-audit fixes, both of which change what the weekly watch reports about this theme. The shipped-chrome pack now outranks the fuzzy matchers, and tokens are judged against the document their rule is actually bound to. Together those retire the `#placesToolbar` finding, which was never a theme bug: that is the Library window's toolbar in places.xhtml, and the audit was proposing `#PlacesToolbar`, the main window's bookmarks toolbar. Applying it would have moved Library styling onto the bookmarks bar. Also fixed upstream: `fxcss upgrade --audit` counted `offscreen` findings as upgrade blockers, the inverse of the `--strict` test. That would have begun refusing upgrades over names Firefox still ships. In-place bump of the three FXCSS_VERSION pins rather than an `fxcss init` regeneration: nothing in the templates changed, and regenerating would drop the publish allowlist entries this repo keeps ahead of them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Theme previewRendered from No pixel differences on any platform — this PR does not change how the browser chrome renders in these views. Views: browser window, focused address bar, find bar, modal dialog — each in light and dark. Native popups (app menu, context menus) are OS-level windows and cannot be captured. Workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Bumps the three
FXCSS_VERSIONpins to 0.20.0, which carries two selector-audit fixes that change what the weekly watch reports about this theme.What 0.20.0 fixes
AdamXweb/fxcss#24 — a name Firefox ships outranks one it merely resembles. The shipped-chrome pack was consulted last, after both fuzzy matchers, so a token Firefox ships under its own spelling could be reported as a typo for an unrelated live element. It now outranks them.
AdamXweb/fxcss#25 — a rule scoped to another document is not judged by this window. The audit had no
@-moz-documenthandling at all: extraction was scope-blind, so every token was compared against DOM collected only from the main browser window. Tokens now carry the binding they were written under.Together those retire the
#placesToolbarfinding, which was never a theme bug.#placesToolbaris the Library window's toolbar (places.xhtml:1154), and our rule is correctly inside@-moz-document url("chrome://browser/content/places/places.xhtml")atparts/places.css:107. The audit was proposing#PlacesToolbar— the main window's bookmarks toolbar,browser.xhtml:6472. Applying it would have moved Library styling onto the bookmarks bar.0.20.0 also fixes
fxcss upgrade --auditcountingoffscreenfindings as upgrade blockers, the inverse of the--stricttest — it would have started refusing upgrades over names Firefox still ships.Measured on this branch, Firefox 153
Running the exact line
firefox-watch.ymluses:#placesToolbarrename#private-browsing-indicator-with-labelSo this PR alone does not silence the watch: it removes the wrong recommendation, and #221 removes the last real one. Both are needed, and they touch different files (workflows vs CSS) so they do not conflict.
Why an in-place bump rather than
fxcss init --forceNothing in the workflow templates changed in 0.20.0, and regenerating would drop the publish allowlist entries this repo deliberately keeps ahead of them.
🤖 Generated with Claude Code