Rock-Saharai Cante🐨#44
Open
scantea wants to merge 5 commits into
Open
Conversation
audreyandoy
reviewed
Jul 12, 2021
audreyandoy
left a comment
audreyandoy
left a comment
There was a problem hiding this comment.
Great work Saharai! You achieved all the learning goals and created such a cute color scheme! I also loved the button animation too. I'm so glad you're having fun with css!
You passed all the tests, I think it was the console.log that made your test submission look funky.
Other than that, keep up the hard work!
Comment on lines
+34
to
+38
| const[currentPlayer,setCurrentPlayer]=useState(PLAYER_1); | ||
| //initial number of squares filled equals 0 | ||
| const[numSquaresFilled,setNumSquaresFilled]=useState(0); | ||
| //intial winner is Null | ||
| const[winner,setWinner] = useState(null); |
There was a problem hiding this comment.
Great use of state to keep track of current player, winner, and filled squares
Comment on lines
110
to
116
| const resetGame = () => { | ||
| // Complete in Wave 4 | ||
| setSquares(generateSquares());//setting squares to intial empty board | ||
| setCurrentPlayer('x'); | ||
| setNumSquaresFilled(0); | ||
| setWinner(null); | ||
| } |
There was a problem hiding this comment.
Great job creating the resetGame function!
Comment on lines
+5
to
+7
| background-color: #0f7deb; | ||
| color: rgb(193, 131, 232); | ||
| border: 6px solid #a1ccf7; |
There was a problem hiding this comment.
Cute!!! Even the kawaii-version branch had an adorable color scheme!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried experimenting on the kawaii-branch but broke some stuff, so submitting the css pretty up version instead with functional code lolol Good Call on the experimental branch Audrey. Thank you!! <3 Some tests arent' passing, due to some changes I've made on the app.js file, but the code seems functional under all conditions? Not sure what happened, maybe i'm not running the tests correctly???