Repository navigation
Conversation
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Spanish was the least covered of the 16 registered locales (757/804, 94.2%): the work report, category builder, search, bucket and notification screens added later were never translated, so Spanish users saw English there. - Translate the 37 remaining English strings in src/i18n/locales/es.ts - Add the eight Spanish values that are legitimately identical to English (h, s, General, Buckets, Hosts, Total, Prompt, Color) to IDENTICAL_OK, the same mechanism pt-BR already uses Coverage is now 804/804 (100%). Translations are machine-drafted, not native-reviewed. Git-Session-Id: c98a97d0-b160-44e5-8d84-e327e8d7a8b3
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryCompletes translations in German, Spanish, Russian, Swedish, and Ukrainian.
TimeToBuildBob explicitly notes that the translations are machine-drafted and have not had native-speaker review. Reviews (1) · Last reviewed commit: "fix(i18n): complete Swedish coverage of ..." · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1177 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 72 72
Lines 4379 4379
Branches 1157 1157
=======================================
Hits 3445 3445
- Misses 880 933 +53
+ Partials 54 1 -53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
All nine checks are green on |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Why
With all 16 locales registered, five had gaps in newer screens (work report,
category builder, search, bucket and notification): de/ru/sv/uk (96.0–96.3%)
and es (94.2%). Spanish users saw the most English; the Germanic and Slavic
locales were close behind.
Consolidates five separate coverage-completion PRs (#1172 es, #1173 de, #1174 ru,
#1175 sv, #1176 uk) into one — per Erik's request to avoid a PR queue bottleneck.
Changes
src/i18n/locales/de.ts— 37 missing strings translatedsrc/i18n/locales/es.ts— 37 missing strings translatedsrc/i18n/locales/ru.ts— 37 missing strings translatedsrc/i18n/locales/sv.ts— 37 missing strings translatedsrc/i18n/locales/uk.ts— 37 missing strings translatedscripts/check-locales.mjs— addesIDENTICAL_OK list (h, s, General, Buckets,Hosts, Total, Prompt, Color are correct Spanish); extend
svIDENTICAL_OK withhandsValidation
node scripts/check-locales.mjs→ all 15 non-English locales at 804/804 (100%)npx tsc --noEmit→ cleanCaveat
Translations are machine-drafted, not native-reviewed. Native-speaker feedback
welcome for any of the five locales.
Closes #1172
Closes #1173
Closes #1174
Closes #1175
Closes #1176