Skip to content

fix(i18n): complete coverage for de, es, ru, sv, uk locales - #1177

Merged
ErikBjare merged 5 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/i18n-complete-coverage-all-locales
Oct 21, 2026
Merged

ErikBjare merged 5 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/i18n-complete-coverage-all-locales

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Why

With all 16 locales registered, five had gaps in newer screens (work report,
category builder, search, bucket and notification): de/ru/sv/uk (96.0–96.3%)
and es (94.2%). Spanish users saw the most English; the Germanic and Slavic
locales were close behind.

Consolidates five separate coverage-completion PRs (#1172 es, #1173 de, #1174 ru,
#1175 sv, #1176 uk) into one — per Erik's request to avoid a PR queue bottleneck.

Changes

  • src/i18n/locales/de.ts — 37 missing strings translated
  • src/i18n/locales/es.ts — 37 missing strings translated
  • src/i18n/locales/ru.ts — 37 missing strings translated
  • src/i18n/locales/sv.ts — 37 missing strings translated
  • src/i18n/locales/uk.ts — 37 missing strings translated
  • scripts/check-locales.mjs — add es IDENTICAL_OK list (h, s, General, Buckets,
    Hosts, Total, Prompt, Color are correct Spanish); extend sv IDENTICAL_OK with
    h and s

Validation

  • node scripts/check-locales.mjs → all 15 non-English locales at 804/804 (100%)
  • npx tsc --noEmit → clean

Caveat

Translations are machine-drafted, not native-reviewed. Native-speaker feedback
welcome for any of the five locales.

Closes #1172
Closes #1173
Closes #1174
Closes #1175
Closes #1176

Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
Spanish was the least covered of the 16 registered locales (757/804, 94.2%): the work report, category builder, search, bucket and notification screens added later were never translated, so Spanish users saw English there.

- Translate the 37 remaining English strings in src/i18n/locales/es.ts
- Add the eight Spanish values that are legitimately identical to English (h, s, General, Buckets, Hosts, Total, Prompt, Color) to IDENTICAL_OK, the same mechanism pt-BR already uses

Coverage is now 804/804 (100%). Translations are machine-drafted, not native-reviewed.

Git-Session-Id: c98a97d0-b160-44e5-8d84-e327e8d7a8b3
Git-Session-Id: 77705124-8359-49aa-a326-2965b441758f
@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Completes translations in German, Spanish, Russian, Swedish, and Ukrainian.

  • Bucket, search, and trend views show translated messages.
  • The category builder guides users in their selected language.
  • The work report asks for a category in the selected language.
  • Notification settings explain their effect in the selected language.
  • Spanish activity guidance and a visualization label are translated.
  • The locale checker accepts selected English terms in Spanish and Swedish.

TimeToBuildBob explicitly notes that the translations are machine-drafted and have not had native-speaker review.

Reviews (1) · Last reviewed commit: "fix(i18n): complete Swedish coverage of ..." · Reviewed by Greptile

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (d7d45cd) to head (73de9fd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files          72       72           
  Lines        4379     4379           
  Branches     1157     1157           
=======================================
  Hits         3445     3445           
- Misses        880      933   +53     
+ Partials       54        1   -53     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

All nine checks are green on 73de9fd1c092, Greptile reports 5/5, and there are no unresolved review threads or merge conflicts. Waiting only on a maintainer merge; Bob has triage permission here, not write permission.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@ErikBjare
ErikBjare merged commit 8ba9a2d into ActivityWatch:master Oct 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants