Repository navigation
fix(packaging): pin Qt Wayland watcher substitution - #1532
TimeToBuildBob wants to merge 1 commit into
Conversation
Git-Session-Id: 80c9911f-26bb-4595-ad10-74955be2f20c
[Medium impact] No established defect blocks merging this pin update. SummaryAdvances
Reviews (1) · Last reviewed commit: "fix(packaging): pin Qt Wayland watcher s..." · Reviewed by Greptile |
|
Greptile reviewed current head b7a4455 at 5/5 with no findings; no human comments or review threads need a response. Platform builds are still pending, with no failed checks so far. No code change or rerun needed now; merge remains maintainer-owned. Rebuilt-bundle runtime verification remains open as documented above. |
🤖 AI code reviewNot reviewedConfidence N/A Not scored — this diff moves a submodule pointer and contains no source to assess. Treat it as not reviewed, not as approved. ℹ️ Submodule pointer change only — not reviewed. This diff moves a submodule SHA and contains no source changes, so there is nothing here for me to assess. Whether the bump is safe depends on the submodule's commit range, which this diff does not include. Treat this as not reviewed, not as approved. Reviewed Maintainer commands
|
Problem
#1531 ships
aw-awatcherin the Linux Qt bundle, but master still pinsaw-qtatfa16bf8, before ActivityWatch/aw-qt#142 and #143. The binary is present but the manager never substitutes it for the X11 watchers.Reproduced using the actual post-#1531 Linux Qt artifact from run 39147683826 (master
c8b9203): it discoversaw-awatcher, then startsaw-watcher-afkandaw-watcher-windowunder headless sway. The X11 watchers fail without DISPLAY and no events reach the isolated test server.Fix
Advance only
aw-qtto merged5fb7634(ActivityWatch/aw-qt#143), including the Wayland detection/substitution and persisted selection fixes from #142/#143. No other submodule or source changes.Verification
aw-qt/tests/test_wayland.pytests passed at the proposed pin.aw-awatcherbinary, selecting the two ordinary X11 watchers logs their substitution and autostartsaw-awatcher.aw-watcher-window_bobevents with appwayland-7b85and titlewayland-7b85-prooffrom a real foot Wayland surface, plusaw-watcher-afk_bobevents.Boundary: this verifies merged manager source + packaged watcher, not a newly rebuilt PyInstaller Qt binary at this pin. The old packaged Qt binary was the negative control. A post-merge rebuilt bundle remains required before declaring the out-of-box bundle verified. Tested sway protocols only, not GNOME/KDE or all Wayland compositors.
Related: #92. Keep the runtime/docs task open until the rebuilt artifact is checked.