Repository navigation
feat(android): add contextual SAF document and folder pickers - #3009
Open
marvin1099 wants to merge 8 commits into
Open
marvin1099 wants to merge 8 commits into
marvin1099 wants to merge 8 commits into
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryAdds Android document creation and context-specific folder picking.
No new actionable issues were found. The earlier keyboard finding is fixed. The supplied fixes for failed-save recovery, browser interaction coverage, and saved tab names are also present. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Save or Save As] --> B{Choose destination}
B --> C[Choose folder]
B --> D[Create Android document]
C --> E[Write editor text]
D --> F[Write editor text to returned URI]
F --> G{Write succeeded?}
G -->|No| H[Keep existing tab identity]
G -->|Yes| I[Update name, URI, and persistence]
I --> J[Mark saved]
E --> J
Reviews (4) · Last reviewed commit: "feat(file-browser): enable device folder..." · Reviewed by Greptile |
marvin1099
force-pushed
the
feat/android-saf-storage
branch
2 times, most recently
from
October 31, 2026 09:29
71fb3e4 to
60227cc
Compare
marvin1099
force-pushed
the
feat/android-saf-storage
branch
from
October 31, 2026 11:07
60227cc to
d6c3746
Compare
marvin1099
force-pushed
the
feat/android-saf-storage
branch
from
November 1, 2026 19:20
d6c3746 to
1d4df2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
EditorFiletest verifies renaming and language switching for a new document.Merge Danger
Door: Two-way; the commits can be reverted independently.
Blast Radius: Medium — Android document save/open and folder-selection flows.
AI was used to make these changes. Feel free to ignore, cherry-pick, or request changes I should make for this PR to be a good fit.