Repository navigation
fix(ios): keep FAQs in-app and preserve website context - #30
Merged
Merged
Conversation
- Add searchable FAQs with sanitized answers, offline caching, timeout handling, and retry feedback. - Preserve iOS context on trusted Acode website links without rewriting encoded query parameters. - Guard asynchronous Help navigation and make search cleanup reliable and accessible. - Add focused regression coverage and update build metadata to 1021. Validation: 18 FAQ, Help, and search-bar tests; Biome checks; production iOS web bundle build (two asset-size warnings).
added 4 commits
November 3, 2026 13:24
Add the missing FAQ error, empty-state, and retry keys to 32 locales using English fallbacks so translation validation passes. Align existing iOS tests with the current file-browser menus, page lifecycle, terminal storage, and standalone worker console. Improve fixture cleanup, wait for keyboard layout, verify persisted icon selection, and isolate gesture and theme tests from ads and startup updates. Validation: 160 iPhone tests and 30 iPad checks passed on iOS 18.6 simulators. Translation validation, formatting, and diff checks passed.
Use macOS 15 with Xcode 26.3 and require iOS 18.6 simulators for StoreKit and alternate-icon testing. Restore the preview safe-area bottom after the keyboard is dismissed on iOS 26, and allow 10 seconds for local SSH/FTP fixture configuration. Validated: 1,072 JavaScript tests, 50 Android tests across three variants, 160 iPhone tests, 30 iPad checks, and 3 iOS 26.2 preview regressions. TypeScript, formatting, translations, and workflow selection checks pass. Simulator runs used local Xcode 27.1; remote CI remains to be verified.
Share consent suppression with debug simulator UI launches so live forms cannot cover test controls. Initialize StoreKit sessions before reloading the app, and wait for a new WebView document instead of fixed reload delays. Wait for preview navigation and title updates, verify fullscreen through native state, retain simulated document pickers, and clean up keyboard fixtures even when setup fails. Preserve the existing feature assertions. Validation: 160 iPhone tests and 30 iPad checks passed on iOS 18.6 with Xcode 27.1, with no skipped tests. Formatter and whitespace checks passed. The separate CI-only Alpine process exits remain unreproduced locally.
- Request platform-specific FAQs, refresh from the network, and reserve the platform-scoped cache for offline fallback while preserving page navigation. - Preserve code and URL destinations when linking changelog references, validate author mentions, and use theme-aware link colors. - Use iOS-specific startup and terminal guidance, open development projects explicitly in Xcode, and avoid redundant preview keyboard constraints. - Add focused regressions and bump versionCode to 1022. Validation: - 39 focused JavaScript tests passed; full suite: 1077 passed, 3 failed, 1 skipped. The same three failures reproduce on origin/main with the installed dependencies. - 13 simulator checks passed on iPhone iOS 26.5 and iPadOS 18.6 each, followed by 5 successful checks after the link-color adjustment. - Production iOS web bundle built; Chrome rendering and visual checks passed. - The known iPad appearance-transition warning occurred in the combined run but did not recur in the isolated console recheck.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
November 4, 2026 12:33
Exclude the 12 Alpine-dependent tests only in GitHub CI while retaining full local coverage and the remaining 150 simulator tests. Forward explicit Xcode skip filters through the iOS test command. Wait for the context menu and its New file action before interacting in the UI test. Validate filter forwarding with focused unit coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation: 18 FAQ, Help, and search-bar tests; Biome checks; production iOS web bundle build (two asset-size warnings).