Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
- Coverage 85.81% 85.17% -0.65%
==========================================
Files 78 74 -4
Lines 17388 15922 -1466
==========================================
- Hits 14921 13561 -1360
+ Misses 2467 2361 -106
Continue to review full report at Codecov.
|
xlc
reviewed
Jan 16, 2022
| PHA("Phala Native Token", 12) = 170, | ||
| KINT("Kintsugi Native Token", 12) = 171, | ||
| KBTC("Kintsugi Wrapped BTC", 8) = 172, | ||
| // BNC("Bifrost Native Token", 12) = 168, |
Member
There was a problem hiding this comment.
This will break compatibility for both SDK and existing runtime storages (e.g. BNC swap pair)
It should be possible to do some migration but it isn't that much beneficial to migrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to: #1773
the
asset-registrymodule could used for not only statemine/statemint assets, but also sibling token(i.e BNC, PHA etc). thus for new sibling token onboard to acala, now we can useregister_foreign_assetdispatch call ofasset-registryinstead of merge PR to acala code base from parachain team.a side-effect is
asset-registryuseforeign-asset-idwhich is number instead ofTokenSymbolenum, thus in front/dapp we may needTokenSymbolmapping toforeign-asset-id, make sure the token mapping is correct.todo list:
FixedRateOfFungible