fix(utility): resolve Windows path handling bugs breaking EXR sequence loading#225
Closed
throb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Closed
fix(utility): resolve Windows path handling bugs breaking EXR sequence loading#225throb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
throb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
…e loading
Three issues prevented image sequences (EXR, etc.) from loading on Windows:
1. Broken backslash regex in scan_posix_path() - the character class [\]
matched ']' instead of '\', leaving backslashes in scanned file paths.
2. pad_size() returned 0 for non-zero-padded frame numbers (e.g. "1000"),
producing invalid %00d / {:00d} format specifiers that failed extension
matching in is_file_supported().
3. posix_path_to_uri() did not normalise backslashes to forward slashes on
Windows, leaking them into file: URIs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
Contributor
|
Hi @throb - thanks for this PR. We have crossed over on this as we (DNEG team) fixed this issue on our branch recently and I have just merged this into the develop & main branches here. Sorry about that. |
Author
|
Great! Glad y’all got a fix
robert nederhorst | vfx supervisor | 3106210103
…On Tue, Mar 24, 2026 at 5:55 AM tedwaine ***@***.***> wrote:
*tedwaine* left a comment (AcademySoftwareFoundation/xstudio#225)
<#225 (comment)>
Hi @throb <https://github.com/throb> - thanks for this PR. We have
crossed over on this as we (DNEG team) fixed this issue on our branch
recently and I have just merged this into the develop & main branches here.
Sorry about that.
—
Reply to this email directly, view it on GitHub
<#225?email_source=notifications&email_token=AABBRMUEAJKQGMARY5LZK4T4SKAVFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJRHAYDGMBZGA3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4118030906>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBRMSKW54LEAI7ZKDYV7T4SKAVFAVCNFSM6AAAAACWPFBYYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMJYGAZTAOJQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scan_posix_path(): The character class[\]matched]instead of\, leaving backslashes in scanned file paths on Windows. Fixed to use\\for proper backslash matching.pad_size()returned 0 for non-zero-padded frame numbers: e.g. frame"1000"produced invalid%00d/{:00d}format specifiers that failed extension matching inis_file_supported(). Now returns the natural width of the frame string.posix_path_to_uri()did not normalise backslashes on Windows: Backslashes leaked intofile:URIs. Added#ifdef _WIN32block to replace\with/before URI construction.Files changed
src/utility/src/helpers.cpp— regex fix + URI backslash normalisationsrc/utility/src/sequence.cpp—pad_size()fixTest plan
image.1000.exr) resolve correctly🤖 Generated with Claude Code