feat: SG-27382: Add 12G SDI single-link support for the AJA Kona 5 card#1198
Open
eloisebrosseau wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
Open
feat: SG-27382: Add 12G SDI single-link support for the AJA Kona 5 card#1198eloisebrosseau wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
eloisebrosseau wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SG-27382: Add 12G SDI single-link support for the AJA Kona 5 card
Linked issues
Fixes #860
Summarize your change.
Note that this PR is based on #1192 that is updating the SDK version used to 17.6.0. The only relevant files to review are KonaVideoDevice.cpp and KonaVideoDevice.h.
This PR adds three new possible data formats if the device can support 12G SDI Single-link on its third port (i.e. SDI Out 3):
Note that the first format enables 6G SDI single-link for low frame rates, and 12G for higher frame rates in YUV.
Since the retail firmware of the Kona 5 doesn't have a built-in TSI muxers, the only supported video formats are the quad ones. Therefore, we need to ensure that 12G statements are executed before quad statements. Moreover, the 4K/8K formats options are simply ignored for the 12G single-link case as TSI is the only possible option if we want to wire the frames to one SDI output.
To avoid refactoring too much code that would affect other AJA cards, the idea here is to only support the 12G SDI single-link workflow based on the Kona 5 retail firmware that only handle it on port 3. To do so, two new functions were added:
route12GSingleLinkYUV()androute12GSingleLinkRGBwhere all the routing is directly handled to go from the frame buffers, to the TSI multiplexers, to the Color spaces converters (if the output format is YUV), to the Dual Link Out (if the output format is RGB), to the third port. To match the rest of the code, we are always using FB 1 and FB 2. The only difference is with the output port.Describe the reason for the change.
This is a feature that was requested by multiple people in the last few years for the AJA Kona 5.
Describe what you have tested and on which operating system.
Tests were performed on macOS 26.3 using a Kona 5 with the retail firmware and a BMD Smartview 4K monitor.
Several YUV and RGB files were tested with the variety of 4K video formats (both UHD and DCI) supported by the card at different resolutions with the 10-bit YUV, 10-bit RGB, and 12-bit RGB data formats that were added specifically to perform 12G SDI Single-link on the third port. Note that the monitor used doesn't support 12G SDI RGB, so only the routing was validated using AJA ntv2watcher tool.