fix: SG-42386: Replace linux commands with CMake#1195
Open
cedrik-fuoco-adsk wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
fix: SG-42386: Replace linux commands with CMake#1195cedrik-fuoco-adsk wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
cedrik-fuoco-adsk
force-pushed
the
SG-42386-replace-linux-commands-all-cmake
branch
from
ef3eb07 to
16a765b
Compare
cedrik-fuoco-adsk
changed the title
Replace all bash+sed and Python-based text processing in the build with a unified CMake script-mode file (apply_sed_filter.cmake). - rv_sed.cmake: use cmake -P on all platforms instead of sed (Unix) or Python (Windows) - rv_lex.cmake: replace bash-based flex version/Apple detection with CMake STRING operations; prefer win_flex on Windows - rv_yacc.cmake: prefer win_bison on Windows; remove dead sed lookup - rv_stage.cmake: replace bash pipeline for .rvpkg version extraction with CMake FILE(READ) + STRING(REGEX MATCH) - MuQt5/MuQt6: use unified apply_sed_filter.cmake for SignalSpy patching The CMake script handles PCRE negative lookbehinds (used in flexfilter.sed) via a three-pass placeholder technique, and literal replacements for yaccfilter.sed and signalspy.sed. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
SG-42386-replace-linux-commands-all-cmake
branch
from
16a765b to
9c02ca7
Compare
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
bernie-laberge
approved these changes
Mar 11, 2026
cedrik-fuoco-adsk
changed the title
eloisebrosseau
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Fixes SG-42386
Summarize your change.
Replace all Unix command-line tool dependencies (
sed,bash,grep,cut,wc,cat) in the CMake build system with pure CMake implementations using a unified CMake script-mode file (apply_sed_filter.cmake) and native CMake string operations.Describe the reason for the change.
The build system relied on Unix tools (
sed,bash -c,grep,cut,wc) for text processing, which are not natively available on Windows. This prevented the build from working on Windows without additional tool installation (e.g., MSYS2/Git Bash).Describe what you have tested and on which operating system.
I looked at the files before and after, and the files looks ok as far as I can tell.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.