feat: improve realtime playback performance especially with prores#1188
Open
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
feat: improve realtime playback performance especially with prores#1188mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
…or slice-based threading. Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1187
Unable to playback prores files due to a buffer that is unable to keep up. This PR fixes that so Prores files playback in realtime by adding the filetypes to slowRandomAccessCodecs
Also noticed that FFMpeg buffers internal frames and RV expects to decode one frame synchronously. FF_THREAD_SLICE exploits multi-core systems and should bring performance improvements.
Before
https://github.com/user-attachments/assets/48703ec6-6816-4d4c-aa7c-b6ce420d39af
After
https://github.com/user-attachments/assets/2362cff2-35c0-4be9-812b-c097bb59576b