fix: Fix mp4 video orientation upside down#1180
Open
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
fix: Fix mp4 video orientation upside down#1180mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
mcoliver
changed the title
…ide down Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
force-pushed
the
fix-mp4-video-orientation-upside-down
branch
from
c7cc39d to
b099ab0
Compare
Contributor
Author
|
@cedrik-fuoco-adsk builds are failing but not due to my commit. Can you nudge them along? |
Contributor
Author
|
@bernie-laberge another one you may want to fast track |
Contributor
|
@mcoliver I restarted the windows job. Do you mind sharing a sample video to reproduce this? or any mp4 will do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1179
Old: (ignore the color shift. this is another bug that will be handled in a separate PR and happens when you clear a session instead of opening a new session)
With this PR:
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.