Update getting_started.rst#2061
Open
mbriamon wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Update getting_started.rst#2061mbriamon wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
mbriamon wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
The directory should be: OpenColorIO/share/docker. Instead of OpenColorIO/shared/docker. I wasn't able to fine /shared/docker. Signed-off-by: mbriamon <130667100+mbriamon@users.noreply.github.com>
The committers listed above are authorized under a signed CLA. |
doug-walker
requested changes
Sep 27, 2024
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Hi Mary, thanks for the contribution!
You change is completely correct about the location of that file. Unfortunately, no one has been maintaining that docker file for years and so it is not something we want people to be using in its current state.
It would be great if you could update that section to point people at this docker image, if they want a pre-built OCIO environment:
https://github.com/AcademySoftwareFoundation/aswf-docker/tree/main/ci-vfxall
Additionally, I would remove the share/docker directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory should be: OpenColorIO/share/docker. Instead of OpenColorIO/shared/docker. I wasn't able to find /shared/docker.