-
Notifications
You must be signed in to change notification settings - Fork 24
[Scala 3] restore positioned.here + SourceInfo.here #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
halotukozak
wants to merge
5
commits into
AVSystem:scala-3
Choose a base branch
from
halotukozak:02-02-source-positions
base: scala-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f589e8
feat(core): restore positioned.here and SourceInfo.here via Scala 3 q…
halotukozak 1c4932b
test(core): add smoke tests for positioned.here and SourceInfo.here
halotukozak 981f5d4
docs(migration): remove restored source-position backlog entries
halotukozak a79fb81
build: re-enable sbt-ci-release plugin (worktree-only workaround leak…
halotukozak edbc3da
test(core): expand PositionedTest with Matchers and additional offset…
halotukozak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
core/src/test/scala/com/avsystem/commons/annotation/PositionedTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package com.avsystem.commons | ||
| package annotation | ||
|
|
||
| import org.scalatest.funsuite.AnyFunSuite | ||
| import org.scalatest.matchers.should.Matchers | ||
|
|
||
| class PositionedTest extends AnyFunSuite with Matchers { | ||
| val point: Int = positioned.here | ||
|
|
||
| test("positioned.here yields distinct positive offsets at distinct call sites") { | ||
| val a = positioned.here | ||
| val b = positioned.here | ||
| assert(a > 0) | ||
| assert(b > 0) | ||
| assert(a != b) | ||
|
halotukozak marked this conversation as resolved.
|
||
| } | ||
|
|
||
| test("positioned.here offset is the start offset of the `positioned.here` term") { | ||
| point shouldBe 214 | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.