Comparison notebook between deep learning and regression-based forecasts - #8
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
geek-yang
marked this pull request as ready for review
June 18, 2023 09:53
Member
Author
|
To review this PR, just check all the changes (the comparison notebook is simply the merge of lstm one and ridge one). |
BSchilperoort
approved these changes
Jun 30, 2023
BSchilperoort
left a comment
BSchilperoort
left a comment
Contributor
There was a problem hiding this comment.
Hi @geek-yang , nice work. I mostly have some textual comments and other small things. Feel free to merge it once you have resolved the issues 👍
Co-authored-by: Bart Schilperoort <b.schilperoort@gmail.com>
Co-authored-by: Bart Schilperoort <b.schilperoort@gmail.com>
Co-authored-by: Bart Schilperoort <b.schilperoort@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To highlight that with "s2spy", users can easily generate some skillful baseline forecasts for their deep learning study, we create this notebook, in which we compare forecasts with LSTM and ridge.