feat(meta): add struct_vuln_rule option for combining structural risk flags#473
Draft
shamykyzer wants to merge 3 commits into
Draft
feat(meta): add struct_vuln_rule option for combining structural risk flags#473shamykyzer wants to merge 3 commits into
shamykyzer wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 99.66% 99.67%
=======================================
Files 28 28
Lines 3633 3651 +18
=======================================
+ Hits 3621 3639 +18
Misses 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #464
struct_vulnin the meta attack vulnerability matrix was hard coded to flag a record when any structural indicator fired (k below threshold, class disclosure, or smallgroup risk)struct_vuln_ruleoption toMetaAttackaccepting"or"(default, behaviour unchanged) or"and"so the flag can require all indicators instead, as the issue asksstructural_attack.combine_risk_flags()since as i read the issue that felt like where it belongs, next to the code that produces the indicators, happy to move it back into meta_attack.py if you'd ratherattack_paramsandglobal_metricsin report.json so downstream readers can tell which rule produced the flagsbehaviour, so a typo fails before any sub attack runs rather than mid workflow