Pr/1 ontology driven core#398
Closed
JessUWE wants to merge 75 commits into
Closed
Conversation
…ression, tables incomplete
acro tables using redaction data falling in vulnerable cells also creating variable metadata
…ven refactoring This commit restores critical module-level constants and functions that were removed during the ontology-driven refactoring but are still required by existing code and tests. Added: - AGGFUNC: Dictionary mapping aggregation function names to implementations - CHECK_MISSING_VALUES: Flag for missing value checking - ZEROS_ARE_DISCLOSIVE: Flag for zero disclosure control - align_masks(): Function to align suppression masks to table structure - apply_suppression(): Function to apply suppression to tables - create_dataframe(): Helper function to combine index and columns - _align_mask_columns(): Helper for mask column alignment - _broadcast_mask_to_multiindex(): Helper for mask replication
Removed unused aggregation function parameters and several mask-related functions to simplify the code. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Fix missing newline at end of file. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Ensure newline at end of file for consistency. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Ensure proper newline at the end of the file. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Refactored evidence accumulation logic in federated mode and removed redundant code. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Fix docstring formatting for agg_nk function. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Refactor docstrings for clarity and update mask_sdc initialization. Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
• Extract _add_federated_output/_add_standalone_output helpers in acro_regression.py to eliminate repeated federated/standalone branching • Clean up finalise_evidence() interface: accept evidence dict directly instead of relying on hidden _federated_evidence_store attribute • Replace print() calls with logger.debug/warning in acro_stata_parser and ontology_handler; remove T201 global ignore from pyproject.toml • Split test_initial.py into test_regressions.py, test_plots.py, and test_federated.py for better test organisation • Fix pre-commit issues: codespell typo, stray print, inline import
…//github.com/AI-SDC/ACRO into 350-feature-adapt-acro-to-be-ontology-driven
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 99.75% 99.23% -0.52%
==========================================
Files 10 16 +6
Lines 1602 2094 +492
==========================================
+ Hits 1598 2078 +480
- Misses 4 16 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.