Skip to content

update_demo_notebook#392

Open
mahaalbashir wants to merge 6 commits into
mainfrom
389-documentation-improve-choice-of-tables-produced-in-the-demo-notebooks
Open

update_demo_notebook#392
mahaalbashir wants to merge 6 commits into
mainfrom
389-documentation-improve-choice-of-tables-produced-in-the-demo-notebooks

Conversation

@mahaalbashir

@mahaalbashir mahaalbashir commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Improve the choice of tables produced in the demo notebook

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (7f3e984) to head (7851ce3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          10       10           
  Lines        1602     1602           
=======================================
  Hits         1598     1598           
  Misses          4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mahaalbashir mahaalbashir requested a review from jim-smith June 24, 2026 10:39
@jim-smith

Copy link
Copy Markdown
Contributor

@mahaalbashir I'm wondering whether we should start by producing the pd.crosstab version of the first table, and then saying:

if you submit just yes, you're going to get an email from the output checkers asking you to produce the table of counts, so that they can check minimum thresholds, and maybe some other data to help them check from 'dominance' if it is financial data. 

For example, did you spot  that cell on the right with mean 1?  How many families are being aggregated to get that  suspiciously integer value?


All this to-and-fro  adds effort and delays to the process.

Acro is designed to help you with this! 
Because you asked for a mean' statistic it knows about the possible risks and so checks them for you (and the output checkers).

Then shows the acro version....

@jim-smith jim-smith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in conversation please.

should we use a different aggregation function for the second table?

@mahaalbashir mahaalbashir requested a review from jim-smith June 30, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] Improve choice of tables produced in the demo notebooks

2 participants