Migrate Android plugin to built-in Kotlin - #76
Merged
Merged
Conversation
Stop applying the Kotlin Gradle Plugin in openidconnect_android and switch to the kotlin.compilerOptions DSL. Bump the package to 2.0.3 and raise the Flutter/Dart floors to 3.44/3.12. Closes #75
There was a problem hiding this comment.
Pull request overview
This pull request migrates the openidconnect_android Flutter federated plugin toward Flutter’s built-in Kotlin flow to improve compatibility with newer Android Gradle Plugin (AGP) versions (including AGP 9), while also bumping the minimum supported Flutter/Dart SDK floors and publishing a new patch release.
Changes:
- Bumped
openidconnect_androidto2.0.3and raised minimum SDK floors to Flutter>=3.44.0/ Dart>=3.12.0. - Updated the Android Gradle configuration to stop applying
kotlin-androidand configure JVM target viakotlin.compilerOptions. - Updated changelog and README to reflect the migration and new requirements.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openidconnect_android/README.md | Updates documented minimum Flutter/Dart requirements. |
| openidconnect_android/pubspec.yaml | Bumps package version and raises environment SDK constraints. |
| openidconnect_android/CHANGELOG.md | Adds 2.0.3 release notes describing the migration and SDK floor changes. |
| openidconnect_android/android/build.gradle | Removes kotlin-android application and configures Kotlin compiler options for JVM 17. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Address Copilot review on #76 by removing the standalone kotlin-gradle-plugin classpath from the Android plugin module.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
openidconnect_android/android/build.gradle:44
lintOptions { ... }is removed in AGP 9; keeping it will break builds on AGP 9+ (which this PR aims to support). Migrate this block to the newlint { ... }DSL.
lintOptions {
disable 'InvalidPackage'
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openidconnect_androidand switch to thekotlin.compilerOptionsDSL so host apps can build on AGP 9.2.0.3.Closes #75.
Test plan
flutter testinopenidconnect_android(7 tests passed)flutter build appbundleforopenidconnect/examplewith Java 17openidconnect_android2.0.3 after merge