remove deprecated active_support.to_time_preserves_timezone (+billing tests)#4228
Open
akostadinov wants to merge 2 commits into3scale:masterfrom
Open
remove deprecated active_support.to_time_preserves_timezone (+billing tests)#4228akostadinov wants to merge 2 commits into3scale:masterfrom
akostadinov wants to merge 2 commits into3scale:masterfrom
Conversation
akostadinov
commented
Feb 18, 2026
|
|
||
| # TODO: we may want to test some of these scenarios in post-paid mode too, mainly the double change test | ||
|
|
||
| # === Trial period plan change tests === |
Contributor
Author
There was a problem hiding this comment.
Do not review commented out tests! They are placeholders that I expect leave little if anything of..
jlledom
reviewed
Feb 24, 2026
Contributor
jlledom
left a comment
jlledom
left a comment
There was a problem hiding this comment.
Why are you mixing to_time zone with billing tests?
Contributor
OK, the tests are about time zones... |
akostadinov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated
And also adds some billing timezone related tests to hopefully assure that it doesn't affect our billing behavior.
Notes to reviewer:
TZ!=UTCbecause we don't officially support such configurations. Also please let me know whether my assessment ofBUGcomments makes sense to you. There are some BUGS in the SUPPORTED USE CASES!If you are from the latter category of person and have a question why we even have
TZ=whatever_elsetests, I want to point out https://access.redhat.com/solutions/3418661 we state:So please accept the
TZ=whatever_elseas descriptive of current behavior and not something to care about fixing at this moment. Although these tests might be useful in the event we decide to start supporting time zone aware billing.