[THREESCALE-11701] Remove redis connection error message from response body in edge limiting policy#1537
Merged
tkan145 merged 1 commit into3scale:masterfrom Feb 24, 2025
Conversation
c192f74 to
1c08e78
Compare
Previously, if redis failed to connect for any reason, the next _M.error() call would call ngx.say and ngx.exit to terminate the current request and send an error back to the client, thereby revealing details about the Redis server. We want to return an error and let the caller decide how to handle the error.
1c08e78 to
20e3b55
Compare
eguzki
approved these changes
Feb 24, 2025
Member
eguzki
left a comment
There was a problem hiding this comment.
Verification steps working like a charm.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix https://issues.redhat.com/browse/THREESCALE-11701
Close #1316
Verification steps
apicast-config.jsonas follow