Skip to content

Conversation

@onelxj
Copy link
Contributor

@onelxj onelxj commented Oct 6, 2025

Without that, it fails on the Jammy image:

Error:  No files matching the pattern were found: "reboot/benchmarks/construct/reports/construct_2025-02-17T03".

Error:  No files matching the pattern were found: "reboot/benchmarks/construct/reports/construct_assign_sync_read_state_id_2025-02-17T03".

https://github.com/reboot-dev/mono/actions/runs/18268773938/job/52007624523?pr=4972

On Focal we get that:

./public/submodules/dev-tools/check-style.sh --full
xargs: file: No such file or directory

https://github.com/reboot-dev/mono/actions/runs/18267517312/job/52004088667

  1. The filename truncation was broken if we have a colon as part of a filename, so we will get a non-existing file name;
  2. So the xargs thing works differently, so it wasn't failing before, but silently continuing with an error and removed the non-existing file from the list of affected files, but now on Jammy it passes it through and then fails when we try to invoke prettier.

@onelxj onelxj self-assigned this Oct 6, 2025
@onelxj onelxj changed the title Filter out benchmarks reports from the code style check Fix issue, where we've generated non-existing names if a filename had a semicolon Oct 6, 2025
@onelxj onelxj force-pushed the onelxj.filter_out_reports branch from a710dd7 to 50fd6d1 Compare October 6, 2025 11:04
@onelxj onelxj changed the title Fix issue, where we've generated non-existing names if a filename had a semicolon Fix issue, where we've generated non-existing names if a filename had a colon Oct 6, 2025
@onelxj onelxj merged commit b9788b1 into main Oct 6, 2025
1 check passed
@onelxj onelxj deleted the onelxj.filter_out_reports branch October 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants