Fix color leakage issue in shader rendering#2425
Open
mathsvisualization wants to merge 1 commit into3b1b:masterfrom
Open
Fix color leakage issue in shader rendering#2425mathsvisualization wants to merge 1 commit into3b1b:masterfrom
mathsvisualization wants to merge 1 commit into3b1b:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Color Leakage in Fragment Shader
Motivation
While rendering overlapping triangles with opposite orientations,
minor color leakage artifacts were observed.
The issue was caused by aggressive alpha scaling in the fragment shader:
This resulted in excessive blending, especially when negatively oriented triangles were involved.
Proposed Changes
This lowers the blending strength and prevents unintended color bleed.
For negatively oriented triangles, the following transformation is used:
if (orientation < 0) a = -a / (1 - a);Mathematically, the modified alpha value is:
a' = -a / (1 - a)This ensures correct cancellation behavior under the standard blending equation:
(1 - alpha) * dst + alpha * src
The transformation guarantees that blending a positively oriented triangle followed by a negatively oriented one restores the original fragment color.
Testing
Result
Before
After