Repository navigation
🧹 Groundskeeper: remove the unused mainframe-theme.md design note - #140
Merged
Merged
Conversation
…root The file describes a theme built on CSS tokens (--card-foreground, --accent-foreground, --color-accent) that no stylesheet or template in this repository defines or uses, and nothing links to it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011MNNzqAL6L8GzZmmNrYM6J
jnnngs
marked this pull request as ready for review
November 11, 2026 17:43
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗂️ Clutter
mainframe-theme.md(471 lines, repository root) documents a "Yorkshire Mainframe Theme" built on CSS custom properties such as--card-foreground,--accent-foregroundand--color-accent, with sample markup to match. No stylesheet or template in this repository defines or uses those tokens, so the file describes a design system this project does not have.🔎 Verification
grep -rE -- '--card-foreground|--color-accent|--accent-foreground'over every.css,.gohtml,.htmland.ymlfile matches onlymainframe-theme.mditself.git grep -i 'mainframe-theme\|Yorkshire Mainframe'finds no reference outside the file: not inREADME.md,docs/,mkdocs.yml,CLAUDE.md,.github/(workflows, Copilot instructions and prompts included),build.shor the Dockerfiles.git log --followshows it has not been edited since the import; its last commit is 16 August.docs/, so it was never published to the site.🎯 Benefit
A reader looking for the dashboard's real styling (
templates/static/css/) no longer finds a root document that names tokens which do not exist. The content stays in git history.✅ Checks
go vet ./...: cleango test -short ./...: all packages pass (the compatibility suite is skipped under-short; this change touches no code)Other candidates, not touched
Jenkinsfilebuildsdir("app"), which was removed in September, so the pipeline cannot work as written. It may still be wired to an external Jenkins server, so it needs a maintainer's call.UI_AUDIT.md(3 October) says "No fixes implemented", yet the commit that added it implemented many of its findings. I could not prove every finding is closed, so it stays.Generated by Claude Code