Task/gsdm 340/data dog sdk basic integration - #31
Merged
srajupusapati merged 4 commits intoSep 3, 2026
Conversation
- setup - service name - user id set - config change
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Tracing is not actually enabled due to an incorrect Trace.equals(...) call, and the Datadog Android dependencies/plugin usage need to be reconciled with module/build configuration to avoid build or instrumentation issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Integrates Datadog into the Android networking stack and Student app lifecycle to collect RUM/logs/traces and associate telemetry with the current user.
Changes:
- Adds Datadog OkHttp interceptor + event listener to shared REST adapters and the data seeding network client.
- Initializes Datadog (RUM/Logs/Tracing) in the Student app and redacts sensitive query parameters from resources/errors.
- Adds Datadog SDK dependencies and introduces the Datadog Gradle plugin dependency in the buildscript.
File summaries
| File | Description |
|---|---|
| libs/canvas-api-2/src/main/java/com/instructure/canvasapi2/CanvasRestAdapter.kt | Adds Datadog OkHttp interceptor + event listener to multiple OkHttp clients. |
| libs/canvas-api-2/build.gradle | Adds Datadog OkHttp/Trace SDK dependencies to the canvas-api-2 library. |
| automation/dataseedingapi/src/main/kotlin/com/instructure/dataseeding/util/CanvasNetworkAdapter.kt | Refactors OkHttp builder creation and injects Datadog OkHttp instrumentation. |
| automation/dataseedingapi/build.gradle | Adds Datadog OkHttp/Trace dependencies to the data seeding module. |
| apps/student/src/main/java/com/instructure/student/util/AppManager.kt | Initializes Datadog (logs/RUM/tracing) and adds URL/message redaction. |
| apps/student/src/main/java/com/instructure/student/fragment/DashboardFragment.kt | Sets Datadog user info from the logged-in user. |
| apps/student/build.gradle | Adds Datadog BuildConfig fields and Datadog SDK dependencies for the Student app. |
| apps/buildSrc/src/main/java/GlobalDependencies.kt | Adds a Datadog Gradle plugin coordinate constant. |
| apps/build.gradle | Adds Datadog Gradle plugin to the buildscript classpath. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+227
to
+236
| Trace.equals( | ||
| TraceConfiguration.Builder().setEventMapper(object : SpanEventMapper { | ||
| override fun map(event: SpanEvent): SpanEvent { | ||
| val originalUrl = event.resource | ||
| event.resource = redactSensitiveData(originalUrl) | ||
| return event | ||
| } | ||
| }) | ||
| .build() | ||
| ) |
Comment on lines
+50
to
+52
| /* Datadog */ | ||
| implementation 'com.datadoghq:dd-sdk-android-okhttp:3.8.0' | ||
| implementation("com.datadoghq:dd-sdk-android-trace:3.8.0") |
Comment on lines
33
to
38
| classpath Plugins.KOTLIN | ||
| classpath Plugins.FIREBASE_CRASHLYTICS | ||
| if (project.coverageEnabled) { classpath Plugins.JACOCO_ANDROID } | ||
| classpath Plugins.HILT | ||
| classpath Plugins.DATADOG | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.