Stop sync poller on stopped Engine.IO sockets#509
Draft
jimmystridh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the sync client callback poller so a stopped Engine.IO socket is handled explicitly instead of being ignored by the polling loop.
When
RawClient::poll()returnsOk(None),Iter::next()producesError::StoppedEngineIoSocket. Before this change,poll_callback()did not treat that error as a stop or reconnect condition, so the callback polling thread could immediately poll again forever.Behavior
StoppedEngineIoSocketwhenreconnectis enabled.StoppedEngineIoSocketwhenreconnectis disabled.Disconnectpacket behavior controlled byreconnect_on_disconnect.Issue
Proposed fix for #508.
Validation
cargo fmt --checkcargo test -p rust_socketio stopped_engineio_socket -- --nocapturecargo test -p rust_socketio socketio_disconnect_obeys_reconnect_on_disconnect -- --nocapturecargo test -p rust_socketio ordinary_packets_keep_polling -- --nocapture