fix: improve compose backup and container restore handling#12192
fix: improve compose backup and container restore handling#12192wanghe-fit2cloud merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d17cb6742c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if info.Driver == "bridge" { | ||
| endpoint.IPAMConfig = nil |
There was a problem hiding this comment.
This now clears endpoint.IPAMConfig for every network using the bridge driver, which also includes user-defined bridge networks. During restore, containers that were intentionally configured with a fixed IP on such networks will lose that assignment and come up with a different address after ContainerCreate/NetworkConnect, which can break service-to-service connectivity that depends on the pinned IP. The IPAM removal should be limited to cases where the address was auto-assigned (or only the default bridge network), not all bridge-driver networks.
Useful? React with 👍 / 👎.
3 participants
No description provided.