Skip to content

fix: 修复删除多个文件夹时确认按钮不显示加载态的问题,并减少删除时不必要的basedir请求#12187

Merged
wanghe-fit2cloud merged 1 commit into1Panel-dev:dev-v2from
wangdage12:dev-v2
Mar 16, 2026
Merged

fix: 修复删除多个文件夹时确认按钮不显示加载态的问题,并减少删除时不必要的basedir请求#12187
wanghe-fit2cloud merged 1 commit into1Panel-dev:dev-v2from
wangdage12:dev-v2

Conversation

@wangdage12
Copy link
Contributor

What this PR does / why we need it?

在删除大量文件夹时,删除对话框的确认按钮不会变为加载态,这会让用户以为删除操作始终未开始,影响用户操作,如果用户继续点击会出现大量并发重复的删除请求。
另外,删除每个文件夹时都会请求basedirapi,在删除多个文件夹时会造成大量重复请求。

PixPin_2026-03-16_17-39-46

Summary of your change

  • 为按钮添加加载态,loading.value = true;原来的位置有问题,已提前至删除操作的顶部
  • 每次整个删除操作只请求一次basedir

PixPin_2026-03-16_17-42-25

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lan-yonghui
Copy link
Member

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Mar 16, 2026
@wanghe-fit2cloud wanghe-fit2cloud merged commit bf1339b into 1Panel-dev:dev-v2 Mar 16, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants